London | May ITP 2025 | Fatima Z Belkedari | Sprint 1 | Array destructuring #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
day-lee
added
the
Review in progress
day-lee
reviewed
Aug 8, 2025
| function displayHogwartsNames ({firstName,lastName}){ | ||
| console.log(`${firstName} ${lastName}`); | ||
| } | ||
| hogwarts.forEach(displayHogwartsNames); |
There was a problem hiding this comment.
You useddisplayHogwartsNames function as a callback function for the forEach method. Being able to pass a function as an argumetn is one of the Java Script's fundamental concepts. Can you name this concept in JS?
day-lee
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Well done for using object destructuring as a parameter!
However, the printed result doesn't quite match to the expected result.
- missing column names: It should print out the column fields: QTY, ITEM, TOTAL in order and correct values for each column.
- number formatting: 232 should be 2.32
- missing Total: total price is missing
Please refactor the code to match the expected result in readme.md
day-lee
added
Reviewed
|
Hi @Farah-Stu, well done for completing the tasks. I left a few comments. Please have a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.